fix(deps): downgrade WalletConnect #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build had no size change
Celo (test) 1.71.0 (136)No changes to report 🛸 Powered by Emerge Tools |
jeanregisser
changed the title
| events "^3.3.0" | ||
|
|
||
| "@walletconnect/utils@2.10.0": | ||
| version "2.10.0" |
There was a problem hiding this comment.
I was able to resolve this modifying the lock file directly, but I am not sure that's ideal. I believe @kathaypacific had to do something similar in the past with the WalletConnect dependencies.
Codecov Report
@@ Coverage Diff @@
## main #4406 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 701 701
Lines 25922 25922
Branches 3432 3432
=======================================
Hits 22008 22008
Misses 3854 3854
Partials 60 60 Continue to review full report in Codecov by Sentry.
|
jeanregisser
approved these changes
Oct 30, 2023
|
@jeanregisser I wonder if we should clear out the sessions and pending requests in a redux migration. |
MuckT
added a commit
that referenced
this pull request
Oct 31, 2023
### Description It appears from [Sentry](https://valora-inc.sentry.io/discover/results/?cursor=0%3A250%3A0&field=title&field=release&field=environment&field=user.display&field=timestamp&name=Error%3A+Unable+to+find+WalletConnect+session+matching+topic+dfe8ce6bc3a89058f7a292b37d934e6f2bbe944a9bc15...&project=1250733&query=issue%3ACELO-MOBILE-EJR&sort=-timestamp&statsPeriod=90d&yAxis=count%28%29) that since v1.68.0 we've had increasing numbers of users hit issues with Wallet connect. This PR reverts upgrades to those dependencies to versions previously used. ### Test plan TBD ### Related issues N/A ### Backwards compatibility Yes
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Upgrades Wallet Connect dependencies to the latest versions: originally pinned in valora-inc#4406. ### Test plan - Tested locally on iOS and Android - Connect - Verify - Sign Transaction ### Related issues - Related: ACT-962 ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears from Sentry that since v1.68.0 we've had increasing numbers of users hit issues with Wallet connect. This PR reverts upgrades to those dependencies to versions previously used.
Test plan
TBD
Related issues
N/A
Backwards compatibility
Yes