chore: remove show receive amount in select provider feature gate #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4859 +/- ##
==========================================
- Coverage 85.20% 85.18% -0.03%
==========================================
Files 712 712
Lines 29222 29186 -36
Branches 5093 5075 -18
==========================================
- Hits 24900 24862 -38
- Misses 4076 4078 +2
Partials 246 246
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
commented
Feb 12, 2024
| @@ -42,11 +42,6 @@ export default onRamps = () => { | |||
| device.getPlatform() === 'ios' | |||
| ? cardProviders.label.split(' ')[0] | |||
| : cardProviders.text.split(' ')[0] | |||
| await element(by.id('Card/section')).tap() | |||
There was a problem hiding this comment.
This is removed as the section now starts as expanded.
MuckT
commented
Feb 12, 2024
| await element(by.id('Card/section')).tap() | ||
| // Check that best rate is displayed first | ||
| await expect( | ||
| element(by.id('Card/provider-0').withDescendant(by.id('Card/bestRate'))) |
There was a problem hiding this comment.
Best Rate no longer displayed.
jophish
reviewed
Feb 12, 2024
|
@jophish looks like the failing e2e test was due to a transient failure with our currency API. |
jh2oman
approved these changes
Feb 14, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…lora-inc#4859) ### Description The `show_receive_amount_in_select_provider` feature gate has been rolled out to 100% since v1.62.0. This is to remove the code path for when that gate returned false. ### Test plan - Tested locally on iOS - Unit Tests updated - E2E tests updated ### Related issues - Fixes ACT-1076 ### Backwards compatibility Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
show_receive_amount_in_select_providerfeature gate has been rolled out to 100% since v1.62.0. This is to remove the code path for when that gate returned false.Test plan
Related issues
Backwards compatibility
Yes