-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(token-import): Adding analytics for the send flow #4901
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4901 +/- ##
==========================================
- Coverage 85.23% 85.23% -0.01%
==========================================
Files 710 710
Lines 29018 29020 +2
Branches 5052 5054 +2
==========================================
Hits 24734 24734
- Misses 4041 4043 +2
Partials 243 243
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there's a bad merge here for the tests. will there be a separate PR for the swap flow analytics? could we also make this PR title more specific to the changes (e.g. adding analytics for send flow) so that the change log is clearer? 🙏🏻
src/tokens/saga.test.ts
Outdated
}) | ||
}) | ||
|
||
describe(fetchImportedTokenBalances, () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a bad merge? it seems like this test group already exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes, I messed it up in the merge 🤯
Yes, the analytics for the swaps are coming with the PR to improve the swap experience for the imported tokens. |
Description
Adding
isTokenManuallyImported
field to the analytics in the send flow.