Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(token-import): Adding analytics for the send flow #4901

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

dievazqu
Copy link
Contributor

Description

Adding isTokenManuallyImported field to the analytics in the send flow.

@dievazqu dievazqu changed the title Adding imported token field to analytics in the send flow chore(token-import): Adding analytics Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28149e3) 85.23% compared to head (c63b3f0) 85.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4901      +/-   ##
==========================================
- Coverage   85.23%   85.23%   -0.01%     
==========================================
  Files         710      710              
  Lines       29018    29020       +2     
  Branches     5052     5054       +2     
==========================================
  Hits        24734    24734              
- Misses       4041     4043       +2     
  Partials      243      243              
Files Coverage Δ
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/send/SendConfirmation.tsx 90.00% <100.00%> (+0.07%) ⬆️
src/send/saga.ts 57.89% <100.00%> (+0.37%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28149e3...c63b3f0. Read the comment docs.

Copy link
Contributor

@bakoushin bakoushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@kathaypacific kathaypacific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there's a bad merge here for the tests. will there be a separate PR for the swap flow analytics? could we also make this PR title more specific to the changes (e.g. adding analytics for send flow) so that the change log is clearer? 🙏🏻

})
})

describe(fetchImportedTokenBalances, () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a bad merge? it seems like this test group already exists?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes, I messed it up in the merge 🤯

@dievazqu dievazqu changed the title chore(token-import): Adding analytics chore(token-import): Adding analytics for the send flow Feb 14, 2024
@dievazqu
Copy link
Contributor Author

i think there's a bad merge here for the tests. will there be a separate PR for the swap flow analytics? could we also make this PR title more specific to the changes (e.g. adding analytics for send flow) so that the change log is clearer? 🙏🏻

Yes, the analytics for the swaps are coming with the PR to improve the swap experience for the imported tokens.
And sorry for the PR title, updated.

@dievazqu dievazqu enabled auto-merge (squash) February 14, 2024 16:18
@dievazqu dievazqu merged commit 31b6061 into main Feb 14, 2024
16 checks passed
@dievazqu dievazqu deleted the diego/imported-tokens-analytics branch February 14, 2024 16:51
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants