fix(jumpstart): correct jumpstart contracts defaultValue
#4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakoushin
changed the title
defaultValuedefaultValue
dievazqu
approved these changes
Feb 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4923 +/- ##
==========================================
- Coverage 85.25% 85.25% -0.01%
==========================================
Files 712 712
Lines 29230 29229 -1
Branches 5088 5088
==========================================
- Hits 24920 24919 -1
Misses 4067 4067
Partials 243 243
Continue to review full report in Codecov by Sentry.
|
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…c#4923) ### Description 1) All possible dynamic config properties must be listed in `defaultValues` when declaring that config. Otherwise, they [won't be forwarded](https://github.com/valora-inc/wallet/blob/a0b4675774579822a6c2ac55e7de38f6658b45c2/src/statsig/index.ts#L29-L34). 2) In addition, it seems more appropriate to use `NetworkId` as network specifier instead of `Network` to enable jumpstart contracts on the testnet as well. ### Test plan * Updated unit tests ### Related issues - Related to RET-999 ### Backwards compatibility Jumpstart functionality is not fully released yet ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All possible dynamic config properties must be listed in
defaultValueswhen declaring that config.Otherwise, they won't be forwarded.
In addition, it seems more appropriate to use
NetworkIdas network specifier instead ofNetworkto enable jumpstart contracts on the testnet as well.Test plan
Related issues
Backwards compatibility
Jumpstart functionality is not fully released yet
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: