Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ESLint plugin to VS Code recommendations list #4939

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

bakoushin
Copy link
Contributor

Description

We have ESLint rules set up, but don't have ESLint plugin among recommendations. This PR aims to fix this.

Test plan

NA

Related issues

NA

Backwards compatibility

NA

Network scalability

NA

@bakoushin bakoushin changed the title chore: add ESLint plugin to recommendations list chore: add ESLint plugin to VS Code recommendations list Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c99402) 85.34% compared to head (177e0b2) 85.34%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4939   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         712      712           
  Lines       29162    29162           
  Branches     5073     5073           
=======================================
+ Hits        24887    24889    +2     
+ Misses       4036     4034    -2     
  Partials      239      239           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c99402...177e0b2. Read the comment docs.

Copy link
Collaborator

@kathaypacific kathaypacific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bakoushin bakoushin merged commit 13449b7 into main Feb 21, 2024
16 checks passed
@bakoushin bakoushin deleted the alex/add-eslint-recommendation-vscode branch February 21, 2024 14:42
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
…4939)

### Description

We have ESLint rules set up, but don't have ESLint plugin among
recommendations. This PR aims to fix this.

### Test plan

NA

### Related issues

NA

### Backwards compatibility

NA

### Network scalability

NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants