ci(e2e): run tests on iOS 17.2 or merges to main #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4989 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 718 719 +1
Lines 29281 29347 +66
Branches 5086 5091 +5
=======================================
+ Hits 25024 25082 +58
- Misses 4018 4026 +8
Partials 239 239
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This comment was marked as outdated.
This comment was marked as outdated.
satish-ravi
approved these changes
Feb 28, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Runs our e2e test suite on iOS 17.2 on merges to main. Also closes simulators at the end of each run to prevent CI machines from having iOS 15.0 and iOS 17.2 simulators active on the machine. ### Test plan - Tested locally on iOS - Tested in CI: [action run](https://github.com/valora-inc/wallet/actions/runs/8071629141/job/22051669825?pr=4989). ### Related issues - Fixes ACT-1102 ### Backwards compatibility N/A ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Runs our e2e test suite on iOS 17.2 on merges to main. Also closes simulators at the end of each run to prevent CI machines from having iOS 15.0 and iOS 17.2 simulators active on the machine.
Test plan
Related issues
Backwards compatibility
N/A
Network scalability
N/A