feat: add jumpstart confirmation screen #5050
Conversation
1 build increased size
Celo (test) 1.79.0 (144)
|
| Item | Install Size Change |
|---|---|
| main.jsbundle | ⬆️ 16.4 kB |
🛸 Powered by Emerge Tools
| @@ -330,11 +330,6 @@ export enum SendEvents { | |||
| send_select_recipient_recent_press = 'send_select_recipient_recent_press', | |||
| } | |||
|
|
|||
| export enum JumpstartEvents { | |||
There was a problem hiding this comment.
Interesting that TS lets us export the same name twice 🤔
| } | ||
|
|
||
| return ( | ||
| <ScrollView contentContainerStyle={styles.container}> |
There was a problem hiding this comment.
nit: maybe we should pad the bottom with the safe area? for when the content can grow big due to a large font for instance
<SafeAreaView edges={['bottom']}>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5050 +/- ##
==========================================
+ Coverage 85.46% 85.53% +0.07%
==========================================
Files 719 722 +3
Lines 29199 29415 +216
Branches 5038 5083 +45
==========================================
+ Hits 24955 25161 +206
- Misses 4014 4021 +7
- Partials 230 233 +3
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
### Description This PR adds: - a new jumpstart confirmation screen. it is just displaying information at this stage. - navigation to this new screen from the enter amount screen - some analytics - unit tests for the new screen Not included: sending the transaction ### Test plan  ### Related issues - Related to RET-994 ### Backwards compatibility Y ### Network scalability Y
Description
This PR adds:
Not included: sending the transaction
Test plan
Related issues
Backwards compatibility
Y
Network scalability
Y