fix: the NFT reward bottom sheet unexpectedly reappears after CTA button is pressed #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5076 +/- ##
=======================================
Coverage 85.57% 85.58%
=======================================
Files 724 724
Lines 29507 29508 +1
Branches 5100 5100
=======================================
+ Hits 25252 25253 +1
Misses 4021 4021
Partials 234 234
Continue to review full report in Codecov by Sentry.
|
1 build decreased size
Celo (test) 1.80.0 (145)
|
| Item | Install Size Change |
|---|---|
| 🗑 splashBackground@3x.jpg | ⬇️ -600.2 kB |
| 🗑 background@3x.jpg | ⬇️ -368.6 kB |
| 🗑 boost-rewards@3x.png | ⬇️ -188.4 kB |
| 🗑 background@2x.jpg | ⬇️ -176.1 kB |
| 🗑 boost-rewards@2x.png | ⬇️ -90.1 kB |
View Treemap
🛸 Powered by Emerge Tools
kathaypacific
approved these changes
Mar 12, 2024
jophish
approved these changes
Mar 12, 2024
jophish
reviewed
Mar 12, 2024
|
|
||
| dispatch(nftRewardDisplayed()) | ||
| dispatch(nftRewardDisplayed()) |
There was a problem hiding this comment.
can this be easily tested? looks like patch coverage is failing
There was a problem hiding this comment.
unfortunately I don't know the way to simulate bottom sheet close.
the only way I see is to trick coverage bot for now.
kathaypacific
pushed a commit
that referenced
this pull request
Mar 13, 2024
…ton is pressed (#5076) ### Description On the iOS production build the NFT reward bottom sheet unexpectedly reappears after CTA button is pressed. The hypothesis is that `onChange` event isn't fired for some reason when the bottom sheet is closed programmatically. The fix is to fire `dispatch` on CTA press handler instead of relying on `onChange` event. Another possible option is to rely on `onClose` event. But unfortunately it is called when component unmounts on Android. ### Test plan Tested manually on: * Android emulator * iOS simulator * dev iOS build on device Planing to additionally test on the nightly iOS build. ### Related issues - Related to RET-1002 ### Backwards compatibility Y ### Network scalability NA
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…ton is pressed (valora-inc#5076) ### Description On the iOS production build the NFT reward bottom sheet unexpectedly reappears after CTA button is pressed. The hypothesis is that `onChange` event isn't fired for some reason when the bottom sheet is closed programmatically. The fix is to fire `dispatch` on CTA press handler instead of relying on `onChange` event. Another possible option is to rely on `onClose` event. But unfortunately it is called when component unmounts on Android. ### Test plan Tested manually on: * Android emulator * iOS simulator * dev iOS build on device Planing to additionally test on the nightly iOS build. ### Related issues - Related to RET-1002 ### Backwards compatibility Y ### Network scalability NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the iOS production build the NFT reward bottom sheet unexpectedly reappears after CTA button is pressed.
The hypothesis is that
onChangeevent isn't fired for some reason when the bottom sheet is closed programmatically.The fix is to fire
dispatchon CTA press handler instead of relying ononChangeevent.Another possible option is to rely on
onCloseevent. But unfortunately it is called when component unmounts on Android.Test plan
Tested manually on:
Planing to additionally test on the nightly iOS build.
Related issues
Backwards compatibility
Y
Network scalability
NA