Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jumpstart): add claim to the names of claim-related actions and selectors #5112

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

bakoushin
Copy link
Contributor

Description

As the title

Test plan

CI

Related issues

Backwards compatibility

Y

Network scalability

NA

Copy link

emerge-tools bot commented Mar 15, 2024

1 build had no size change

Name Version Download Change Install Change Approval
Celo (test)
org.celo.mobile.test
1.80.0 (145) 24.2 MB ⬆️ 1.1 kB 60.3 MB - N/A

Celo (test) 1.80.0 (145)
org.celo.mobile.test

No changes to report


🛸 Powered by Emerge Tools

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (52b1bbb) to head (2f20878).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5112   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files         724      724           
  Lines       29641    29640    -1     
  Branches     5121     5121           
=======================================
  Hits        25350    25350           
+ Misses       4056     4055    -1     
  Partials      235      235           
Files Coverage Δ
src/jumpstart/selectors.ts 100.00% <100.00%> (ø)
src/jumpstart/slice.ts 62.50% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05faa1...2f20878. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bakoushin bakoushin added this pull request to the merge queue Mar 16, 2024
Merged via the queue into main with commit eb588aa Mar 16, 2024
16 checks passed
@bakoushin bakoushin deleted the alex/fix-jumpstart-status-naming branch March 16, 2024 09:17
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
…nd selectors (valora-inc#5112)

### Description

As the title

### Test plan

CI

### Related issues

- Related to RET-1004

### Backwards compatibility

Y

### Network scalability

NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants