chore(toast): update toast UI to use border instead of shadow #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5113 +/- ##
==========================================
- Coverage 85.52% 85.52% -0.01%
==========================================
Files 724 724
Lines 29640 29639 -1
Branches 5121 5120 -1
==========================================
- Hits 25351 25350 -1
Misses 4054 4054
Partials 235 235
Continue to review full report in Codecov by Sentry.
|
This reverts commit bbc1381.
kathaypacific
approved these changes
Mar 18, 2024
|
I had the same feeling when Apple went from skeuomorphism to flat back in the day. But in the end, it went well. Let's wait and see if this one could make it. |
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…-inc#5113) ### Description We decided to refrain from using shadows with toasts because shadows don't give enough contrast with the underlying app surface for toast to stand out. It is also challenging to replicate designer-proposed shadows consistently in iOS and Android due to platform differences in rendering shadows. A border with 50% opaque primary color is used instead. Designs: https://www.figma.com/file/erFfzHvSTm5g1sjK6jWyEH/Working-Design-System-Components?type=design&node-id=1287-1599&mode=design&t=FfkYhPWuxiEi75yJ-0 Context: https://valora-app.slack.com/archives/C0684TXDR3K/p1710432893238009?thread_ts=1708337311.090779&cid=C0684TXDR3K #### Examples: | With border | With shadow (deprecated) | |--------|--------| |  |  | |  |  | |  |  | |  |  | ### Test plan CI ### Related issues - Related to RET-1004 ### Backwards compatibility Y ### Network scalability NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We decided to refrain from using shadows with toasts because shadows don't give enough contrast with the underlying app surface for toast to stand out.
It is also challenging to replicate designer-proposed shadows consistently in iOS and Android due to platform differences in rendering shadows.
A border with 50% opaque primary color is used instead.
Designs: https://www.figma.com/file/erFfzHvSTm5g1sjK6jWyEH/Working-Design-System-Components?type=design&node-id=1287-1599&mode=design&t=FfkYhPWuxiEi75yJ-0
Context: https://valora-app.slack.com/archives/C0684TXDR3K/p1710432893238009?thread_ts=1708337311.090779&cid=C0684TXDR3K
Examples:
Test plan
CI
Related issues
Backwards compatibility
Y
Network scalability
NA