test(e2e): update tests to run against tab navigator #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
commented
Mar 21, 2024
| @@ -9,6 +9,9 @@ describe('Account', () => { | |||
| }) | |||
|
|
|||
| describe('Support', Support) | |||
There was a problem hiding this comment.
not doing a describe.each here because not all tests need to run against both navs, see Support.js for tests running against both variants
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5140 +/- ##
==========================================
+ Coverage 85.70% 85.71% +0.01%
==========================================
Files 729 729
Lines 29833 29854 +21
Branches 5154 5160 +6
==========================================
+ Hits 25568 25589 +21
Misses 4030 4030
Partials 235 235 see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
approved these changes
Mar 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Updates the following tests - AccountManagement.spec.js - updates to run against both variants - Pin.spec.js - updates to run against both variants - Verify.spec.js - updated to run against tab navigator (no need for drawer here since there's sufficient coverage against drawer settings) - WalletConnect.spec.js - still runs agains the drawer (hard to override statsig gate since app launched from deeplink in some cases) but reuses the `navigateToSettings` helper so its easier to update when tab is rolled out ### Test plan CI ### Related issues - Part of ACT-1113 ### Backwards compatibility N/A ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the following tests
navigateToSettingshelper so its easier to update when tab is rolled outTest plan
CI
Related issues
Backwards compatibility
N/A
Network scalability
N/A