test(e2e): add new account creation test for new tab and cloud backup #5142
Conversation
There was a problem hiding this comment.
This is exactly NewAccountOnboarding.js before the above changes
1 build increased size
Celo (test) 1.81.0 (146)
|
| Item | Install Size Change |
|---|---|
| 📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
| 📝 background@3x.jpg | ⬆️ 368.6 kB |
| 📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
| 📝 background@2x.jpg | ⬆️ 176.1 kB |
| 📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
View Treemap
🛸 Powered by Emerge Tools
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5142 +/- ##
==========================================
- Coverage 85.71% 85.71% -0.01%
==========================================
Files 729 729
Lines 29854 29854
Branches 5160 5160
==========================================
- Hits 25590 25589 -1
- Misses 4029 4030 +1
Partials 235 235 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -262,6 +262,7 @@ | |||
| "eslint-plugin-react-hooks": "^4.6.0", | |||
| "eslint-plugin-react-native": "^4.0.0", | |||
| "ethers": "^5.7.2", | |||
| "expect": "^29.7.0", | |||
There was a problem hiding this comment.
fixes a knip error. We use expect directly in e2e tests. It was previously a transitive dependency from jest which knip doesn't allow https://knip.dev/guides/handling-issues#unlisted-dependencies
| @@ -121,20 +123,22 @@ export default NewAccountOnboarding = () => { | |||
| }) | |||
|
|
|||
| it('Account Address shown in drawer menu', async () => { | |||
There was a problem hiding this comment.
nit: no longer drawer menu.
…valora-inc#5142) ### Description Renames existing NewAccountOnboarding test to NewAccountOnboardingDrawer and updates NewAccountOnboarding to run against tab navigator and cloud backup ### Test plan CI ### Related issues - Part of ACT-1113 ### Backwards compatibility N/A ### Network scalability N/A
Description
Renames existing NewAccountOnboarding test to NewAccountOnboardingDrawer and updates NewAccountOnboarding to run against tab navigator and cloud backup
Test plan
CI
Related issues
Backwards compatibility
N/A
Network scalability
N/A