feat(swaps): add dropdown network filter #5174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5174 +/- ##
==========================================
- Coverage 85.76% 85.76% -0.01%
==========================================
Files 744 744
Lines 30294 30320 +26
Branches 5226 5237 +11
==========================================
+ Hits 25983 26004 +21
- Misses 4072 4077 +5
Partials 239 239
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
reviewed
Mar 27, 2024
1 build increased size
Celo (test) 1.81.0 (146)
|
| Item | Install Size Change |
|---|---|
| main.jsbundle | ⬆️ 8.2 kB |
🛸 Powered by Emerge Tools
satish-ravi
approved these changes
Mar 28, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Dropdown for filtering swap tokens by network [Figma](https://www.figma.com/file/gFuRy5HJrV34ehkY0dvWWb/Swap-guidance?type=design&node-id=2708-3698&mode=design&t=l0AoyI5xCPHiauyq-0) [Android](https://github.com/valora-inc/wallet/assets/8432644/7aaf789f-904b-4a06-988a-a3a8fae23713) [iOS](https://github.com/valora-inc/wallet/assets/8432644/98ff2060-f4fa-446f-98e3-b6b8de4d7496) ### Test plan Updated unit tests ### Related issues https://linear.app/valora/issue/ACT-1098/select-token-by-network ### Backwards compatibility <!-- Brief explanation of why these changes are/are not backwards compatible. --> ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dropdown for filtering swap tokens by network
Figma
Screen_recording_20240327_123510.webm
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-03-27.at.12.46.38.mp4
Test plan
Updated unit tests
Related issues
https://linear.app/valora/issue/ACT-1098/select-token-by-network
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: