feat: Add icon overlay with one Eth asset on Arbitrum or Optimism #5175
Conversation
chriskeating603
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5175 +/- ##
=======================================
Coverage 85.76% 85.77%
=======================================
Files 744 744
Lines 30320 30324 +4
Branches 5237 5237
=======================================
+ Hits 26005 26011 +6
+ Misses 4076 4074 -2
Partials 239 239
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ios/.xcode.env
Outdated
There was a problem hiding this comment.
I don't think there's harm in committing this file: ios/.xcode.env, but it would be good to check with others.
There was a problem hiding this comment.
Oh I can remove that if it is not standard to add to this file
1 build increased size
Celo (test) 1.81.0 (146)
|
| Item | Install Size Change |
|---|---|
| 📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
| 📝 background@3x.jpg | ⬆️ 368.6 kB |
| 📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
| 📝 background@2x.jpg | ⬆️ 176.1 kB |
| 📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
View Treemap
🛸 Powered by Emerge Tools
chriskeating603
force-pushed
the
add-icon-overlay-with-one-asset
branch
from
4c5ee08
to
6af2948
Compare
| tokenBalances: { | ||
| [mockEthTokenId]: { | ||
| ...mockTokenBalances[mockEthTokenId], | ||
| balance: '0.508480716806023', |
There was a problem hiding this comment.
nit: these balances could all just be '1' for readability.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…lora-inc#5175) ### Description Currently, when a user has one balance of Eth, users cannot tell the difference between on different networks (Ethereum, Arbitrum, Optimism). This change add an network icon over the token icon for Eth when held on either Arb or Op. ### Test plan Tests for presence of TokenIcon and presence / absence of NetworkIcon depending on network, and passes all tests. ### Related issues - Fixes ACT-1086 ### Backwards compatibility Passes all previous tests ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will continue to work without code changes but will require additional testing for new changes
Description
Currently, when a user has one balance of Eth, users cannot tell the difference between on different networks (Ethereum, Arbitrum, Optimism). This change add an network icon over the token icon for Eth when held on either Arb or Op.
Test plan
Tests for presence of TokenIcon and presence / absence of NetworkIcon depending on network, and passes all tests.
Related issues
Backwards compatibility
Passes all previous tests
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will continue to work without code changes but will require additional testing for new changes