fix: handle large fonts with twelve word seed phrases #5187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build had no size change
Celo (test) 1.81.0 (146)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5187 +/- ##
==========================================
+ Coverage 85.76% 85.77% +0.01%
==========================================
Files 744 744
Lines 30324 30343 +19
Branches 5237 5238 +1
==========================================
+ Hits 26007 26028 +21
+ Misses 4078 4076 -2
Partials 239 239
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jh2oman
approved these changes
Apr 1, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Currently large fonts can display the 12 word seed phrase with letters rendered off screen or covered index numbers. This PR fixes that by using the fontScale to display as either four rows with three columns or six rows with two columns. ### Screenshots | iOS Large Font (Before) | iOS Large Font (After) | iOS Default Font (Before) | iOS Default Font (After) | | ----- | ----- | ----- | ----- | |  |  |  |  | | Android Large Font (Before) | Android Large Font (After) | Android Default Font (Before) | Android Default Font (After) | | ----- | ----- | ----- | ----- | |  |  |  |  | ### Test plan - Tested locally on iOS - Tested locally on Android ### Related issues - Fixes ACT-1073 ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently large fonts can display the 12 word seed phrase with letters rendered off screen or covered index numbers. This PR fixes that by using the fontScale to display as either four rows with three columns or six rows with two columns.
Screenshots
Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A