feat: support deep link swap pairs and to tokenId #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build increased size
Celo (test) 1.82.0 (147)
|
| Item | Install Size Change |
|---|---|
| 📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
| 📝 background@3x.jpg | ⬆️ 368.6 kB |
| 📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
| 📝 background@2x.jpg | ⬆️ 176.1 kB |
| 📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
View Treemap
🛸 Powered by Emerge Tools
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5216 +/- ##
=======================================
Coverage 85.77% 85.77%
=======================================
Files 744 744
Lines 30351 30353 +2
Branches 5240 5241 +1
=======================================
+ Hits 26033 26035 +2
Misses 4079 4079
Partials 239 239
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Adds the route param toTokenId to the SwapScreenWithBack screen allowing the use of a deep link to set the to tokenId. This enables the creation of deep link which contains a swap pair or a target to token. ### Test plan Prerequisites: - Remove `isSecureOrigin` from https://github.com/valora-inc/wallet/blob/main/src/app/saga.ts#L348 for local testing. - Use iOS mainnetDev with `yarn dev:ios -e mainnetdev` Tests urls: - Swap pair: `celo://wallet/openScreen?screen=SwapScreenWithBack&fromTokenId=celo-mainnet:native&toTokenId=celo-mainnet:0x765de816845861e75a25fca122bb6898b8b1282a` - From token: `celo://wallet/openScreen?screen=SwapScreenWithBack&fromTokenId=celo-mainnet:native` - To token: `celo://wallet/openScreen?screen=SwapScreenWithBack&toTokenId=celo-mainnet:native` - No tokens: `celo://wallet/openScreen?screen=SwapScreenWithBack` ### Related issues N/A ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the route param toTokenId to the SwapScreenWithBack screen allowing the use of a deep link to set the to tokenId.
This enables the creation of deep link which contains a swap pair or a target to token.
Test plan
Prerequisites:
isSecureOriginfrom https://github.com/valora-inc/wallet/blob/main/src/app/saga.ts#L348 for local testing.yarn dev:ios -e mainnetdevTests urls:
celo://wallet/openScreen?screen=SwapScreenWithBack&fromTokenId=celo-mainnet:native&toTokenId=celo-mainnet:0x765de816845861e75a25fca122bb6898b8b1282acelo://wallet/openScreen?screen=SwapScreenWithBack&fromTokenId=celo-mainnet:nativecelo://wallet/openScreen?screen=SwapScreenWithBack&toTokenId=celo-mainnet:nativecelo://wallet/openScreen?screen=SwapScreenWithBackRelated issues
N/A
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: