fix(qr): land on send screen when scanning with 0 balance #5265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5265 +/- ##
==========================================
- Coverage 85.91% 85.89% -0.03%
==========================================
Files 745 745
Lines 30487 30484 -3
Branches 5288 5287 -1
==========================================
- Hits 26192 26183 -9
- Misses 4059 4065 +6
Partials 236 236
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
approved these changes
Apr 17, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…#5265) ### Description send navigation was blocked on a `canSendTokensSelector` which uses a deprecated tokens selector that only checks celo tokens and returns true if the at least one celo network token has a balance > 0 and a local currency exchange rate is available. The new send flow can handle both these scenarios, and we want to navigate to the zero state send screen, so this check is removed ### Test plan | Before | After | |--------|--------| | <video src="https://github.com/valora-inc/wallet/assets/5062591/279b6b1e-e9ac-4974-832d-2b4c0612df69" /> | <video src="https://github.com/valora-inc/wallet/assets/5062591/625788c9-fd1b-48bc-9b30-e61afad1df40" /> | ### Related issues - Fixes ACT-1148 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
send navigation was blocked on a
canSendTokensSelectorwhich uses a deprecated tokens selector that only checks celo tokens and returns true if the at least one celo network token has a balance > 0 and a local currency exchange rate is available. The new send flow can handle both these scenarios, and we want to navigate to the zero state send screen, so this check is removedTest plan
qr-scan-zero-balance-before.mp4
qr-scan-zero-balance-after.mp4
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: