fix(points): only fetch config if points are enabled #5278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5278 +/- ##
=======================================
Coverage 86.01% 86.01%
=======================================
Files 747 747
Lines 30516 30522 +6
Branches 5290 5291 +1
=======================================
+ Hits 26247 26253 +6
Misses 4037 4037
Partials 232 232
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bakoushin
approved these changes
Apr 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
### Description As the title. ### Test plan n/a ### Related issues - Related to RET-1044 ### Backwards compatibility Y ### Network scalability Y
MuckT
pushed a commit
that referenced
this pull request
Apr 19, 2024
### Description As the title. ### Test plan n/a ### Related issues - Related to RET-1044 ### Backwards compatibility Y ### Network scalability Y
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description As the title. ### Test plan n/a ### Related issues - Related to RET-1044 ### Backwards compatibility Y ### Network scalability Y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title.
Test plan
n/a
Related issues
Backwards compatibility
Y
Network scalability
Y