feat(onboarding): add terms and conditions colloquial variant #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5293 +/- ##
=======================================
Coverage 86.01% 86.02%
=======================================
Files 746 746
Lines 30520 30537 +17
Branches 5291 5294 +3
=======================================
+ Hits 26252 26268 +16
- Misses 4036 4037 +1
Partials 232 232
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
reviewed
Apr 22, 2024
MuckT
approved these changes
Apr 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…-inc#5293) ### Description Implements the colliquial terms variant for the terms and conditions experiment. - [Figma](https://www.figma.com/file/mthUlChSbWXXxLe2AV13Wd/Onboarding-2024?type=design&node-id=2071-2370&mode=design&t=Z20oNRHCqe8eUHLs-0) - [statsig experiment](https://console.statsig.com/4plizaPmWwPL21ASV4QAO0/experiments/onboarding_terms_and_conditions/setup) ### Test plan | | Control | Colloquial | |--------|--------|--------| | iOS | <video src="https://github.com/valora-inc/wallet/assets/5062591/e53f3c26-caee-4a0c-b63b-1e8bf48dcf0f" /> | <video src="https://github.com/valora-inc/wallet/assets/5062591/b62b96e0-de82-4d3b-98f2-28fd73d509af" /> | | Android | <video src="https://github.com/valora-inc/wallet/assets/5062591/bf56c776-4efa-4462-9408-4e28277afe74" /> | <video src="https://github.com/valora-inc/wallet/assets/5062591/f064397b-a830-42b0-950a-e6398a8e6b15" /> | ### Related issues - Part of ACT-1162 ### Backwards compatibility N/A ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the colliquial terms variant for the terms and conditions experiment.
Test plan
ios-tc-control.mp4
ios-tc-colloquial.mp4
android-tc-control.webm
android-tc-colloquial.webm
Related issues
Backwards compatibility
N/A
Network scalability
N/A