feat(wallet-tab): include error message when token fetching fails #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
force-pushed
the
satish/clean-balances
branch
from
f8b884b
to
cf9d38a
Compare
satish-ravi
commented
Apr 23, 2024
| @@ -713,109 +721,3 @@ describe.each([ | |||
| expect(getElementText(tree.getByTestId('TotalTokenBalance'))).toEqual('₱-') | |||
| }) | |||
| }) | |||
|
|
|||
| describe('renders the network icon on the home screen to differentiate between ETH on Ethereum, Arbitrum, and Optimism', () => { | |||
There was a problem hiding this comment.
these tests were superfluous, as it was testing the underlying behavior of TokenIcon component using HomeTokenBalance, just updated a test in FiatExchangeTokenBalance to ensure TokenIcon is displayed when there's a single token with balance as HomeTokenBalance is going to be removed as part of the drawer nav cleanup
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5308 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 747 747
Lines 30623 30624 +1
Branches 5308 5308
=======================================
+ Hits 26353 26355 +2
+ Misses 4038 4037 -1
Partials 232 232
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
silasbw
approved these changes
Apr 24, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…lora-inc#5308) ### Description The home token balance component included a toast error message when token fetching fails. This adds the same to the wallet tab. Also added more tests for AssetsTokenBalance (used in the wallet tab) and cleaned up some redundant tests in preparation for removing the home token balance (part of cleaning up the drawer nav) ### Test plan Unit tests, manually failing the token fetch request ### Related issues - Part of ACT-1133 ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The home token balance component included a toast error message when token fetching fails. This adds the same to the wallet tab. Also added more tests for AssetsTokenBalance (used in the wallet tab) and cleaned up some redundant tests in preparation for removing the home token balance (part of cleaning up the drawer nav)
Test plan
Unit tests, manually failing the token fetch request
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: