test(e2e): run all tests against tab navigator #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5325 +/- ##
==========================================
- Coverage 86.09% 86.08% -0.01%
==========================================
Files 747 747
Lines 30716 30716
Branches 5320 5320
==========================================
- Hits 26444 26441 -3
- Misses 4040 4043 +3
Partials 232 232 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
finnian0826
reviewed
Apr 24, 2024
jh2oman
approved these changes
Apr 24, 2024
MuckT
approved these changes
Apr 24, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description As part of removing the drawer nav, run all e2e tests against the tab navigator and remove drawer nav specific tests. WalletConenct test still runs against drawer because it uses openUrl to launch app and there isn't an easy way to specify a launchArg ### Test plan CI ### Related issues - Part of ACT-1133 ### Backwards compatibility Yes ### Network scalability Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of removing the drawer nav, run all e2e tests against the tab navigator and remove drawer nav specific tests. WalletConenct test still runs against drawer because it uses openUrl to launch app and there isn't an easy way to specify a launchArg
Test plan
CI
Related issues
Backwards compatibility
Yes
Network scalability
Yes