feat(swap): enable app fee via remote config

[jeanregisser]

Description

This PR allows enabling the swap fee via the remote config.

When enabled, the free Valora swap fee line item is hidden.
The details of the Valora fee are then displayed when hitting the info button of the exchange rate line item.

Test plan

• Updated tests

Valora fee disabled	Valora fee enabled (0 fee from API)	Valora fee enabled (positive fee from API)

Notes:

• copies are not final
• the "Valora fee disabled" case is same as today except it also shows the info icon next to the exchange rate.

Related issues

• Fixes RET-1061

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

• Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

[codecov]

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.06%. Comparing base (2bbc26b) to head (3bc37a9).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5359      +/-   ##
==========================================
+ Coverage   85.90%   86.06%   +0.15%     
==========================================
  Files         737      735       -2     
  Lines       30140    29967     -173     
  Branches     5165     5133      -32     
==========================================
- Hits        25891    25790     -101     
+ Misses       4017     3950      -67     
+ Partials      232      227       -5     

Files	Coverage Δ
src/analytics/Properties.tsx	100.00% <ø> (ø)
src/statsig/constants.ts	100.00% <ø> (ø)
src/swap/SwapTransactionDetails.tsx	91.30% <100.00%> (+0.98%)	⬆️
src/swap/types.ts	100.00% <ø> (ø)
src/swap/useSwapQuote.ts	93.25% <100.00%> (+0.31%)	⬆️
src/swap/SwapScreen.tsx	94.01% <84.61%> (-0.39%)	⬇️

... and 23 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbc26b...3bc37a9. Read the comment docs.

[kathaypacific]

LGTM!! i wondered if we want to hard code "valora" in variable names and translation keys / params for the fees? we've tried to be brand agnostic in the code so far so wanted to check that this was an intentional move (i was thinking that the readability wouldn't be affected if we omit the "valora" part)

[jeanregisser]

LGTM!! i wondered if we want to hard code "valora" in variable names and translation keys / params for the fees? we've tried to be brand agnostic in the code so far so wanted to check that this was an intentional move (i was thinking that the readability wouldn't be affected if we omit the "valora" part)

It's intentional, but I see your point.
If we remove the "valora" part I think it's way less clear what this is, cause we already have network fee, gas fee, and soon cross-chain fee.
Just calling it "swap fee" may be a bit ambiguous I think, as there are liquidity pool swap fees already which we don't really see.
Maybe we could call it appFee? or appEditorFee? or swapApiFee?