ci: upload detox build to emerge on merge queue runs #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuckT
approved these changes
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5360 +/- ##
==========================================
+ Coverage 85.92% 86.05% +0.13%
==========================================
Files 738 735 -3
Lines 30173 29948 -225
Branches 5168 5123 -45
==========================================
- Hits 25925 25773 -152
+ Misses 4016 3948 -68
+ Partials 232 227 -5 see 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
### Description Some main runs fail to upload this because E2E-main runs are skipped if multiple PRs merge at the same time (or if some fail due to test flake). This ensures a commit on main always uploads a build to emerge. More context here: https://valora-app.slack.com/archives/C02E2FE98P2/p1713968251987719 ### Test plan Watch CI run on merge queue ### Related issues N/A ### Backwards compatibility N/A ### Network scalability N/A
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Some main runs fail to upload this because E2E-main runs are skipped if multiple PRs merge at the same time (or if some fail due to test flake). This ensures a commit on main always uploads a build to emerge. More context here: https://valora-app.slack.com/archives/C02E2FE98P2/p1713968251987719 ### Test plan Watch CI run on merge queue ### Related issues N/A ### Backwards compatibility N/A ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some main runs fail to upload this because E2E-main runs are skipped if multiple PRs merge at the same time (or if some fail due to test flake). This ensures a commit on main always uploads a build to emerge.
More context here: https://valora-app.slack.com/archives/C02E2FE98P2/p1713968251987719
Test plan
Watch CI run on merge queue
Related issues
N/A
Backwards compatibility
N/A
Network scalability
N/A