feat(points): Implement empty state for points history bottom sheet #5361
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5361 +/- ##
=======================================
Coverage 86.05% 86.06%
=======================================
Files 735 735
Lines 29946 29952 +6
Branches 5122 5125 +3
=======================================
+ Hits 25771 25778 +7
+ Misses 3948 3947 -1
Partials 227 227
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
looks good, although the "learn more" button felt a odd to me because it feels like it should do something more than just dismissing the sheet. i wonder if it'd be better for the button text to say something like "got it"? or for us to link to a support article? just my 2c though, if you and Kayla want to leave it like this then that's also fine
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…alora-inc#5361) ### Description Implements the empty state for the points history bottom sheet. See designs [here](https://www.figma.com/file/rXBDplfMHHqYmuu6EkgMEo/Gamification-experiments?type=design&node-id=1486-5899&mode=design&t=gVtyIzOM0LmxJaDy-4). ### Test plan Units and manual tested. See video below https://github.com/valora-inc/wallet/assets/569401/b9ed634a-4784-4c6a-a7db-fdbeaf9eb395 ### Related issues - Fixes #[issue number here] ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Description
Implements the empty state for the points history bottom sheet. See designs here.
Test plan
Units and manual tested. See video below
empty-state-2024-04-29_11.02.03.mp4
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: