feat: add stablecoin earn feature gate #5373
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5373 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 735 735
Lines 29946 29947 +1
Branches 5122 5122
=======================================
+ Hits 25771 25772 +1
Misses 3948 3948
Partials 227 227
Continue to review full report in Codecov by Sentry.
|
| @@ -27,6 +27,7 @@ export const FeatureGates = { | |||
| [StatsigFeatureGates.SHOW_NFT_REWARD]: false, | |||
| [StatsigFeatureGates.SHOW_JUMPSTART_SEND]: false, | |||
| [StatsigFeatureGates.SHOW_POINTS]: false, | |||
| [StatsigFeatureGates.SHOW_STABLECOIN_EARN]: false, | |||
There was a problem hiding this comment.
nit on naming: "SHOW_EARN" instead?
There was a problem hiding this comment.
we talked and debated between the two. show_earn is a bit short, but as long as we continue calling it Earn we should be fine.
Show_stablecoin_earn is also nice if we intend on this only being for the mvp. I don't feel too strongly
There was a problem hiding this comment.
I think if we anticipate this to be long lived token, we can change to show_earn. But almost all of our features have been specific to one release, which is why I went with show_stablecoin_earn. So unless we have a case for this being a long lived token (e.g., if we want to have some region lock for this feature), I lean towards show_stablecoin_earn.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
### Description Just setting up the gate in the code, will be used in subsequent PRs ### Test plan N/A ### Related issues - Fixes ACT-1183 ### Backwards compatibility Yes ### Network scalability N/A
Description
Just setting up the gate in the code, will be used in subsequent PRs
Test plan
N/A
Related issues
Backwards compatibility
Yes
Network scalability
N/A