Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): downgrade lottie until breaking changes are resolved #5380

Merged
merged 2 commits into from
May 3, 2024

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented May 2, 2024

Description

Downgrades lottie to fix broken animations in 6.x.

Test plan

  • Tested locally in Android

Related issues

N/A

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (0852de1) to head (526675d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5380      +/-   ##
==========================================
- Coverage   86.06%   86.06%   -0.01%     
==========================================
  Files         735      735              
  Lines       29984    29984              
  Branches     5139     5139              
==========================================
- Hits        25807    25806       -1     
- Misses       3950     3951       +1     
  Partials      227      227              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0852de1...526675d. Read the comment docs.

Copy link

emerge-tools bot commented May 2, 2024

1 build decreased size

Name Version Download Change Install Change Approval
Celo (test)
org.celo.mobile.test
1.84.0 (149) 27.0 MB ⬇️ 337.2 kB (-1.24%) 64.2 MB ⬇️ 818.5 kB (-1.26%) N/A

Celo (test) 1.84.0 (149)
org.celo.mobile.test

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬇️ 818.5 kB (-1.26%)
Total download size change: ⬇️ 337.2 kB (-1.24%)

Largest size changes

Item Install Size Change
Lottie ⬇️ -427.9 kB
Code Signature ⬇️ -40.9 kB
DYLD.Exports ⬇️ -25.0 kB
DYLD.Fixups ⬇️ -10.2 kB
CoreGraphics._NativeDictionary._copyOrMoveAndResize(capacity,move... ⬇️ -9.5 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

@MuckT MuckT added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@MuckT MuckT added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 06b92f8 May 3, 2024
16 checks passed
@MuckT MuckT deleted the tomm/lottie-downgrade-5.1.6 branch May 3, 2024 00:42
jeanregisser pushed a commit that referenced this pull request May 3, 2024
)

### Description

Downgrades lottie to fix broken animations in 6.x.

### Test plan

- Tested locally in Android

### Related issues

N/A

### Backwards compatibility

Yes

### Network scalability

N/A
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
…lora-inc#5380)

### Description

Downgrades lottie to fix broken animations in 6.x.

### Test plan

- Tested locally in Android

### Related issues

N/A

### Backwards compatibility

Yes

### Network scalability

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants