fix(discover): fix a crash when dapp list is empty #5382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5382 +/- ##
=======================================
Coverage 86.06% 86.07%
=======================================
Files 735 735
Lines 29984 29984
Branches 5139 5139
=======================================
+ Hits 25807 25808 +1
+ Misses 3950 3949 -1
Partials 227 227
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
approved these changes
May 2, 2024
jeanregisser
pushed a commit
that referenced
this pull request
May 3, 2024
### Description Fixes an edge case where if dapps don't load the first time (or comes back as an empty list), navigating to the discover tab crashes the app. This is because we render the dapps section using a boolean condition (`categories.length && <SectionList />`) and if the array length is 0, it attempts to render `0`, which is outside of a Text component ### Test plan Manually by setting dapps list to empty list and ensuring the app no longer crashes ### Related issues N/A ### Backwards compatibility Yes ### Network scalability N/A
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Fixes an edge case where if dapps don't load the first time (or comes back as an empty list), navigating to the discover tab crashes the app. This is because we render the dapps section using a boolean condition (`categories.length && <SectionList />`) and if the array length is 0, it attempts to render `0`, which is outside of a Text component ### Test plan Manually by setting dapps list to empty list and ensuring the app no longer crashes ### Related issues N/A ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an edge case where if dapps don't load the first time (or comes back as an empty list), navigating to the discover tab crashes the app. This is because we render the dapps section using a boolean condition (
categories.length && <SectionList />) and if the array length is 0, it attempts to render0, which is outside of a Text componentTest plan
Manually by setting dapps list to empty list and ensuring the app no longer crashes
Related issues
N/A
Backwards compatibility
Yes
Network scalability
N/A