feat(earn): fetch apy from contract #5389
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5389 +/- ##
==========================================
- Coverage 86.08% 86.07% -0.01%
==========================================
Files 737 739 +2
Lines 30016 30040 +24
Branches 5143 5143
==========================================
+ Hits 25838 25858 +20
- Misses 3950 3954 +4
Partials 228 228
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/web3/networkConfig.ts
Outdated
| const ARB_USDC_TOKEN_ID_MAINNET = `${NetworkId['arbitrum-one']}:0xaf88d065e77c8cc2239327c5edb3a432268e5831` | ||
|
|
||
| const ARB_AAVE_CONTRACT_ADDRESS_STAGING = '0xBfC91D59fdAA134A4ED45f7B584cAf96D7792Eff' | ||
| const ARB_AAVE_CONTRACT_ADDRESS_MAINNET = '0x794a61358D6845594F94dc1DB02A252b5b4814aD' |
There was a problem hiding this comment.
Nit: change the name to specify that this is the Pool contract.
There was a problem hiding this comment.
can you add "v3" too? e.g., ...AAVE_POOL_V3_CONTRACT...
satish-ravi
changed the title
src/abis/AavePool.ts
Outdated
There was a problem hiding this comment.
Is there a place to verify the contents of this file for Aave?
There was a problem hiding this comment.
nit: add the V3 to the filename
### Description Add a fetch function that gets APY from aave contract ### Test plan Unit tests, manual ### Related issues - Fixes ACT-1174 ### Backwards compatibility Yes ### Network scalability N/A
Description
Add a fetch function that gets APY from aave contract
Test plan
Unit tests, manual
Related issues
Backwards compatibility
Yes
Network scalability
N/A