Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swap): Initial Swap screen redesign #5409
feat(swap): Initial Swap screen redesign #5409
Changes from 11 commits
d8f41c3
6318608
f5083e7
7a769e8
9866c10
db30579
cd5b22e
17e7db7
09f9b33
9138ac2
68668ff
bdb0d91
4555251
7a95688
6851300
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i got really hung up on this even though it's not important because it's not easy to understand what
useForeground
means. (also readingif useForeground, use background
is weird). it seems like this prop should be usedif the Touchable has any images as children and you want the ripple to be rendered above the image
- so perhaps a more intuitive prop for this component could beshouldRenderRippleAbove
orrippleAboveImages
orhasImageChildren
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agreed that it's weird as-is... I like
shouldRenderRippleAbove
, since it does have utility outside of using images within the Touchable.