Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): get gas padding from dynamic config #5418

Merged
merged 1 commit into from
May 15, 2024

Conversation

satish-ravi
Copy link
Contributor

@satish-ravi satish-ravi commented May 15, 2024

Description

As the title

Test plan

Unit tests, manual
Successful tx: https://sepolia.arbiscan.io/tx/0xe681a97041ad016ecfae008111285db3b14a60a5054abd5912109af2987245d0
https://arbiscan.io/tx/0x3a72d7edf302f4d88ae86dc42bbffd87b95d47ee9b4a1a0723ddee13cd30954f

earn-submit-successful-deposit.mp4

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (14a2d7e) to head (d079352).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5418      +/-   ##
==========================================
- Coverage   86.17%   86.16%   -0.01%     
==========================================
  Files         748      748              
  Lines       30384    30388       +4     
  Branches     5187     5187              
==========================================
+ Hits        26183    26185       +2     
- Misses       3973     3975       +2     
  Partials      228      228              
Files Coverage Δ
src/earn/prepareTransactions.ts 97.72% <100.00%> (+0.22%) ⬆️
src/statsig/constants.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a2d7e...d079352. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 71554e2 May 15, 2024
17 checks passed
@satish-ravi satish-ravi deleted the satish/act-1178-gas-padding branch May 15, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants