-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(buttons): Change onboarding buttons to new design #5423
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5423 +/- ##
==========================================
+ Coverage 86.23% 86.27% +0.03%
==========================================
Files 750 754 +4
Lines 30557 30847 +290
Branches 5216 5273 +57
==========================================
+ Hits 26351 26612 +261
- Misses 3978 4008 +30
+ Partials 228 227 -1
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
The paste button on restore wallet looks a bit weird, should that one stay as the old version? It feels weird to keep around the style for just one use case, but I'm not seeing any other way to override color to white. |
Looks like this sets a rounded: false property, but the gray with border type doesn't seem to honor it and always sets a borderRadius. I'd suggest we fix this if its simple, or leave onboarding_secondary as deprecated and use it in one place, with a follow up ticket |
Kept onboarding secondary as it was used for the paste button and looks weird in a different style, added a follow-up ticket for removing the deprecated style: https://linear.app/valora/issue/ACT-1200/placeholder-remove-deprecated-onboarding-button-style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching the undesired change with the paste button!
Description
Update the onboarding buttons
Test plan
unit/e2e tests pass
Manual Tests:
![Simulator Screenshot - iPhone 14 Pro - 2024-05-16 at 12 33 56](https://private-user-images.githubusercontent.com/140328381/331343426-f616523d-e24b-46f3-bff1-650b51c7f0ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwNDk5MDAsIm5iZiI6MTcyMDA0OTYwMCwicGF0aCI6Ii8xNDAzMjgzODEvMzMxMzQzNDI2LWY2MTY1MjNkLWUyNGItNDZmMy1iZmYxLTY1MGI1MWM3ZjBhZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QyMzMzMjBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MTAzYThiZDJhMTU4ZWM2NGIxMjk0ZjUzZTFmNzE1ODE5ZTNkMDY0YzdkNzIzZGMxM2QwYTQ5MmI5ZDI5MDIyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.zh81Sa-E9WOYqOHPYHKMY9_GtGmGwp57PPoeTAuPQJI)
![Simulator Screenshot - iPhone 14 Pro - 2024-05-16 at 12 34 02](https://private-user-images.githubusercontent.com/140328381/331343445-fea7646c-cda6-470d-b5b4-3f30b6bb1842.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwNDk5MDAsIm5iZiI6MTcyMDA0OTYwMCwicGF0aCI6Ii8xNDAzMjgzODEvMzMxMzQzNDQ1LWZlYTc2NDZjLWNkYTYtNDcwZC1iNWI0LTNmMzBiNmJiMTg0Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QyMzMzMjBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zMzJlMWMyMDYwMjVkNGQ2OGJhMWZjODczNWQ4OWE0NGRjMTc3YTlhZTVmZTA3ZjY2OWNhODJhOWEyMmNhMjBmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.nwtz52aqFQ_DcOhPbeoLL36R46pOOCbFZdeZ4X52dWI)
![Simulator Screenshot - iPhone 14 Pro - 2024-05-16 at 12 34 25](https://private-user-images.githubusercontent.com/140328381/331343460-2ab26ff4-89dd-4a58-a8bc-6f2cd0bebc1b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwNDk5MDAsIm5iZiI6MTcyMDA0OTYwMCwicGF0aCI6Ii8xNDAzMjgzODEvMzMxMzQzNDYwLTJhYjI2ZmY0LTg5ZGQtNGE1OC1hOGJjLTZmMmNkMGJlYmMxYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwM1QyMzMzMjBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00MmE1MDcyN2Q2Y2ZmYTNhN2NlNzE1MmRjMGFjOWZjODE0MmRkN2FjNTMxZGJhMjdhODRhOGRmMjA2YmU1ZmEzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.oAT6m3NkeJTqdc6C1L-YsH7pQFZZYe0RWxyT3j2WxAo)
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: