Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): add function for preparing withdraw transactions #5426

Merged
merged 2 commits into from
May 17, 2024

Conversation

satish-ravi
Copy link
Contributor

Description

As the title

Test plan

Unit tests, manually by invoking this function

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.27%. Comparing base (db2a063) to head (dc30eeb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5426      +/-   ##
==========================================
- Coverage   86.27%   86.27%   -0.01%     
==========================================
  Files         753      753              
  Lines       30679    30700      +21     
  Branches     5236     5238       +2     
==========================================
+ Hits        26468    26485      +17     
- Misses       3984     3988       +4     
  Partials      227      227              
Files Coverage Δ
src/earn/prepareTransactions.ts 95.38% <90.47%> (-2.35%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2a063...dc30eeb. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 99d3822 May 17, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/act-1180-prepare-withdraw-tx branch May 17, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants