feat(earn): prepare transactions on the collect screen and display gas #5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5428 +/- ##
=======================================
Coverage 86.27% 86.28%
=======================================
Files 754 754
Lines 30785 30825 +40
Branches 5257 5274 +17
=======================================
+ Hits 26559 26596 +37
- Misses 3999 4002 +3
Partials 227 227
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
force-pushed
the
satish/act-1180-collect-prepare-tx
branch
from
7d228a8
to
7c6f4bd
Compare
satish-ravi
force-pushed
the
satish/act-1180-collect-prepare-tx
branch
from
7c6f4bd
to
64fd9eb
Compare
MuckT
reviewed
May 17, 2024
src/earn/hooks.ts
Outdated
| rewards: asyncRewardsInfo.result, | ||
| poolTokenAddress: poolTokenInfo.address, | ||
| }) | ||
| }, [asyncRewardsInfo.result]) |
There was a problem hiding this comment.
Should we log the error with onError from useAsync?
MuckT
reviewed
May 17, 2024
src/earn/hooks.ts
Outdated
| const walletAddress = useSelector(walletAddressSelector) | ||
| const allTokens = useTokensList() | ||
|
|
||
| return useAsync( | ||
| const asyncRewardsInfo = useAsync( | ||
| async () => { | ||
| if (!poolTokenInfo || !poolTokenInfo.address) { | ||
| throw new Error(`Token with id ${networkConfig.aaveArbUsdcTokenId} not found`) |
There was a problem hiding this comment.
Suggested change
| throw new Error(`Token with id ${networkConfig.aaveArbUsdcTokenId} not found`) | |
| throw new Error(`Token with id ${poolTokenId} not found`) |
MuckT
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates hook to prepare txs after rewards info is fetched and then use prepared txs to display gas fee on the collect screen
Test plan
Unit tests, manual
earn-load-prepared-tx.mp4
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: