feat(earn): redux setup for withdraw #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
force-pushed
the
satish/act-1180-collect-prepare-tx
branch
from
7c6f4bd
to
64fd9eb
Compare
satish-ravi
force-pushed
the
satish/act-1180-withdraw-redux-setup
branch
from
15960ee
to
22f956b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5429 +/- ##
==========================================
- Coverage 86.29% 86.28% -0.02%
==========================================
Files 754 754
Lines 30825 30839 +14
Branches 5274 5274
==========================================
+ Hits 26601 26610 +9
- Misses 3997 4002 +5
Partials 227 227
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
approved these changes
May 17, 2024
| interface State { | ||
| depositStatus: 'idle' | 'started' | 'success' | 'error' | ||
| depositStatus: Status |
There was a problem hiding this comment.
Eventually have to handle multiple pools so deposit and withdraw status could need to be represented differently, but I think for the MVP this is fine.
satish-ravi
force-pushed
the
satish/act-1180-withdraw-redux-setup
branch
from
4ced741
to
cc63b8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also changed from started -> loading to be consistent with other slices
Test plan
Unit tests
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: