Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): Add feature gate for covering gas fees #5437

Merged
merged 2 commits into from
May 20, 2024

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented May 20, 2024

Description

feature gate: https://console.statsig.com/4plizaPmWwPL21ASV4QAO0/gates/subsidize_stablecoin_earn_gas_fees

Test plan

N/A

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (6c3366d) to head (fc4ba52).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5437      +/-   ##
==========================================
+ Coverage   86.32%   86.33%   +0.01%     
==========================================
  Files         755      755              
  Lines       30887    30943      +56     
  Branches     5276     5281       +5     
==========================================
+ Hits        26664    26716      +52     
- Misses       3996     4000       +4     
  Partials      227      227              
Files Coverage Δ
src/statsig/constants.ts 100.00% <ø> (ø)
src/statsig/types.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3366d...fc4ba52. Read the comment docs.

@@ -28,6 +28,7 @@ export const FeatureGates = {
[StatsigFeatureGates.SHOW_JUMPSTART_SEND]: false,
[StatsigFeatureGates.SHOW_POINTS]: false,
[StatsigFeatureGates.SHOW_STABLECOIN_EARN]: false,
[StatsigFeatureGates.COVER_STABLECOIN_EARN_GAS_FEES]: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: SUBSIDIZE instead of COVER? (it seems like that's the term we've been using 🤷 )

@MuckT MuckT enabled auto-merge May 20, 2024 21:19
@MuckT MuckT added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@finnian0826 finnian0826 added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit d03677c May 20, 2024
17 checks passed
@finnian0826 finnian0826 deleted the finnian0826/earn-cover-gas-fees-feature-gate branch May 20, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants