Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(earn): consolidate analytics events #5450

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

Description

Use consistent naming, include some common properties in events

Test plan

Unit tests

Related issues

N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.33%. Comparing base (a36105f) to head (f95db9b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5450      +/-   ##
==========================================
- Coverage   86.34%   86.33%   -0.02%     
==========================================
  Files         756      757       +1     
  Lines       31233    31244      +11     
  Branches     5364     5364              
==========================================
+ Hits        26967    26973       +6     
- Misses       4033     4038       +5     
  Partials      233      233              
Files Coverage Δ
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/earn/EarnCollectScreen.tsx 97.77% <100.00%> (+0.02%) ⬆️
src/earn/EarnDepositBottomSheet.tsx 98.48% <100.00%> (+0.07%) ⬆️
src/earn/EarnEnterAmount.tsx 81.18% <100.00%> (+0.09%) ⬆️
src/earn/constants.ts 100.00% <100.00%> (ø)
src/earn/saga.ts 94.96% <100.00%> (+0.12%) ⬆️
src/earn/EarnActivePool.tsx 94.11% <71.42%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36105f...f95db9b. Read the comment docs.

interface EarnDepositProperties {
tokenId: string
interface EarnCommonProperties {
providerId: 'aave-v3'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this be PROVIDER_ID instead of 'aave-v3'

@silasbw silasbw added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 8b27b0a May 22, 2024
16 checks passed
@silasbw silasbw deleted the satish/earn-analytics branch May 22, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants