Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add jsx expressions linter #5463

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

Description

ESLint rule that catches conditional rendering bugs. More context here

Test plan

CI

Related issues

N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.37%. Comparing base (37e365e) to head (498b957).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5463      +/-   ##
==========================================
- Coverage   86.37%   86.37%   -0.01%     
==========================================
  Files         757      757              
  Lines       31312    31310       -2     
  Branches     5388     5386       -2     
==========================================
- Hits        27047    27045       -2     
  Misses       4034     4034              
  Partials      231      231              
Files Coverage Δ
src/RevokePhoneNumber.tsx 98.03% <100.00%> (ø)
src/account/AccountErrorScreen.tsx 100.00% <100.00%> (ø)
src/account/Education.tsx 78.26% <100.00%> (ø)
src/components/Avatar.tsx 100.00% <100.00%> (ø)
src/components/BackButton.tsx 100.00% <ø> (ø)
src/components/BottomSheet.tsx 93.54% <100.00%> (ø)
src/components/Dialog.tsx 97.14% <100.00%> (ø)
src/components/IconWithNetworkBadge.tsx 91.66% <100.00%> (ø)
src/components/InLineNotification.tsx 100.00% <100.00%> (ø)
src/components/PercentageIndicator.tsx 100.00% <100.00%> (ø)
... and 27 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e365e...498b957. Read the comment docs.

Copy link
Collaborator

@silasbw silasbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks so much 🚀 🚀

@satish-ravi satish-ravi added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 9adf90e May 24, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/jsx-expresssions-lint branch May 24, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants