feat(earn): Add EarnHome screen #5656

finnian0826 · 2024-07-18T22:14:30Z

Description

Move over necessary multi-pool earn stuff from earnV2. Two pools shown for testing purposes but the PR only includes the single Aave pool currently supported.

Will add analytics and hook stuff up in follow-up PRs

Test plan

all.mp4

Open pools	My pools	Bottom sheet

Related issues

Part of ACT-1260

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

codecov · 2024-07-18T22:37:43Z

Codecov Report

Attention: Patch coverage is 82.77512% with 36 lines in your changes missing coverage. Please review.

Project coverage is 86.74%. Comparing base (98966fa) to head (caeba91).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5656      +/-   ##
==========================================
- Coverage   86.77%   86.74%   -0.04%     
==========================================
  Files         774      779       +5     
  Lines       31807    32015     +208     
  Branches     5216     5243      +27     
==========================================
+ Hits        27602    27770     +168     
- Misses       4157     4197      +40     
  Partials       48       48

Files	Coverage Δ
src/components/FilterChipsCarousel.tsx	`100.00% <100.00%> (ø)`
src/earn/EarnTabBar.tsx	`100.00% <100.00%> (ø)`
src/earn/PoolList.tsx	`100.00% <100.00%> (ø)`
src/earn/types.ts	`100.00% <100.00%> (ø)`
src/navigator/Screens.tsx	`100.00% <100.00%> (ø)`
src/components/TokenBottomSheet.tsx	`96.02% <66.66%> (-0.60%)`	⬇️
src/earn/PoolCard.tsx	`89.74% <89.74%> (ø)`
src/earn/EarnHome.tsx	`73.50% <73.50%> (ø)`

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98966fa...caeba91. Read the comment docs.

finnian0826 · 2024-07-19T21:47:01Z

src/dapps/DappsScreen.tsx

@@ -240,8 +240,6 @@ function DappsScreen({ navigation }: Props) {
                <FilterChipsCarousel
                  chips={filterChips}
                  onSelectChip={handleToggleFilterChip}
-                  primaryColor={Colors.successDark}


This defaults to gray/black buttons, Kayla mentioned wanting this standard across the app here

satish-ravi · 2024-07-20T00:06:06Z

src/components/FilterChipsCarousel.tsx

+  primaryColor?: colors
+  primaryBorderColor?: colors
+  primaryTextColor?: colors
+  secondaryColor?: colors
+  secondaryBorderColor?: colors
+  secondaryTextColor?: colors


can we drop these params if there's no usage of customizing? The less options the better. Also, would be nice if the styling change for this component is in a separate PR

moved to #5672

satish-ravi · 2024-07-20T00:09:40Z

src/components/TokenBottomSheet.tsx

@@ -33,6 +34,7 @@ export enum TokenPickerOrigin {
  CashIn = 'CashIn',
  CashOut = 'CashOut',
  Spend = 'Spend',
+  EarnFilter = 'EarnFilter',


Suggested change

EarnFilter = 'EarnFilter',

Earn = 'Earn',

?

satish-ravi · 2024-07-20T00:11:58Z

src/earn/EarnHome.test.tsx

+]
+
+describe('EarnHome', () => {
+  it('renders correctly', () => {


needs tests for changing tabs / filtering

satish-ravi · 2024-07-20T00:13:34Z

src/navigator/Navigator.tsx

@@ -538,6 +539,7 @@ const generalScreens = (Navigator: typeof Stack) => (

 const earnScreens = (Navigator: typeof Stack) => (
  <>
+    <Navigator.Screen name={Screens.EarnHome} component={EarnHome} options={headerWithBackButton} />


use custom header over nav header to avoid the header not greying out when the bottom sheet is open

I'm having some trouble getting a custom header to work with the useScrollAwareHeader to have scrolling work and the title show up on the top. Is there any example of getting these to work together that we have, I'm having trouble finding one. @satish-ravi @MuckT

useScrollAwareHeader is meant to work with nav header and not custom header. We'll likely need a new wrapper for custom headers, which is beyond the scope of this. Let's make an issue

src/earn/PoolCard.tsx

satish-ravi · 2024-07-20T00:20:22Z

src/earn/EarnHome.tsx

+  {
+    poolId: 'aArbUSDCn',
+    networkId: NetworkId['arbitrum-one'],
+    tokens: [`${NetworkId['arbitrum-one']}:0xaf88d065e77c8cc2239327c5edb3a432268e5831`],


For now I think we are going to support pools where this list is going to be the same as the deposit token id. I guess this is needed for more complex pools, @jeanregisser do you see value in keeping this?

It's fine, it'll be part of the position anyway. I'll update this as I start working on the task to connect it to getEarnPositions.

satish-ravi · 2024-07-23T22:51:47Z

src/earn/EarnTabBar.test.tsx

+import { EarnTabType } from 'src/earn/types'
+import Colors from 'src/styles/colors'
+
+describe('AssetTabBar', () => {


satish-ravi · 2024-07-23T22:51:54Z

src/earn/EarnTabBar.test.tsx

+    jest.clearAllMocks()
+  })
+
+  it('renders all items if positions is enabled', () => {


this test name doesn't seem right

updated, had copied over these tests from AssetTabBar and missed updating title

satish-ravi · 2024-07-23T22:53:29Z

src/earn/PoolCard.tsx

+          <View style={styles.buttonContainer}>
+            <Button
+              onPress={() => {
+                navigate(Screens.EarnCollectScreen, { depositTokenId, poolTokenId })


satish-ravi · 2024-07-23T22:53:35Z

src/earn/PoolCard.tsx

+            />
+            <Button
+              onPress={() => {
+                navigate(Screens.EarnEnterAmount, { tokenId: depositTokenId })


satish-ravi · 2024-07-23T22:55:20Z

src/earn/EarnHome.test.tsx

+    expect(getByTestId(`PoolCard/${pools[0].poolId}`)).toBeTruthy()
+  })
+
+  it('correctly shows correct networks, tokens under filters', () => {


can we also add tests for changing filters?

This might be difficult with the current hardcoded single pool. There isn't any way to specify for the home screen to show more pools, so the pools being shown wouldn't change at all.

satish-ravi · 2024-07-23T22:59:50Z

src/components/TokenBottomSheet.tsx

@@ -215,6 +217,9 @@ function TokenBottomSheet({
          if (isNetworkChip(filter)) {
            return filter.filterFn(token, filter.selectedNetworkIds)
          }
+          if (isTokenSelectChip(filter)) {


is this just to make TS happy? the token bottom sheet itself isn't going to have a token filter chip right?

This is just copied over from Jacob's implementation in Troopo, I can remove if not necessary, the token bottom sheet won't have filters I don't think

satish-ravi · 2024-07-23T23:01:47Z

src/navigator/Navigator.tsx

@@ -538,6 +539,7 @@ const generalScreens = (Navigator: typeof Stack) => (

 const earnScreens = (Navigator: typeof Stack) => (
  <>
+    <Navigator.Screen name={Screens.EarnHome} component={EarnHome} options={headerWithBackButton} />


useScrollAwareHeader is meant to work with nav header and not custom header. We'll likely need a new wrapper for custom headers, which is beyond the scope of this. Let's make an issue

finnian0826 added 3 commits July 18, 2024 16:14

feat(earn): Add EarnHome screen

2f31aff

update root state schema

61ff0e3

Merge branch 'main' into finnian0826/act-1257-add-screen

115a96e

finnian0826 added 7 commits July 18, 2024 16:46

more cleanup

6a9dce4

more updates

4857382

more stuff

fe68a8c

fix translation

4ed0ccc

add tests

5e1e444

fix translation string

12af004

Merge branch 'main' into finnian0826/act-1257-add-screen

8ff64b9

finnian0826 marked this pull request as ready for review July 19, 2024 21:16

finnian0826 added 2 commits July 19, 2024 15:17

fix merge

96ce7fd

lint

632b386

finnian0826 commented Jul 19, 2024

View reviewed changes

satish-ravi reviewed Jul 20, 2024

View reviewed changes

finnian0826 added 6 commits July 23, 2024 14:49

feedback pt. 1

c50fb11

feedback pt. 2

54b9a93

Merge branch 'main' into finnian0826/act-1257-add-screen

f9f74ff

fix bottom sheet

05a243a

add tests

84a35cd

clean up

8ddaa28

satish-ravi reviewed Jul 23, 2024

View reviewed changes

small feedback

caeba91

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(earn): Add EarnHome screen #5656

feat(earn): Add EarnHome screen #5656

finnian0826 commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

finnian0826 Jul 19, 2024

satish-ravi Jul 20, 2024

finnian0826 Jul 23, 2024

satish-ravi Jul 20, 2024

satish-ravi Jul 20, 2024

satish-ravi Jul 20, 2024

finnian0826 Jul 23, 2024 •

edited

Loading

satish-ravi Jul 23, 2024

satish-ravi Jul 20, 2024 •

edited

Loading

jeanregisser Jul 23, 2024

satish-ravi Jul 23, 2024

satish-ravi Jul 23, 2024

finnian0826 Jul 23, 2024

satish-ravi Jul 23, 2024

satish-ravi Jul 23, 2024

satish-ravi Jul 23, 2024

finnian0826 Jul 23, 2024

satish-ravi Jul 23, 2024

finnian0826 Jul 23, 2024

satish-ravi Jul 23, 2024

feat(earn): Add EarnHome screen #5656

Are you sure you want to change the base?

feat(earn): Add EarnHome screen #5656

Conversation

finnian0826 commented Jul 18, 2024 • edited Loading

Description

Test plan

Related issues

Backwards compatibility

Network scalability

codecov bot commented Jul 18, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

finnian0826 Jul 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satish-ravi Jul 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

finnian0826 commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

finnian0826 Jul 23, 2024 •

edited

Loading

satish-ravi Jul 20, 2024 •

edited

Loading