fix(swap): ensure long running cross chain swaps eventually shows completed status #5704
Conversation
| transactionHash: transaction.transactionHash || '', | ||
| block: '', | ||
| fees: [], | ||
| ...transaction, // in case the transaction already has the above (e.g. cross chain swaps), use the real values |
There was a problem hiding this comment.
this small change ensures the received pending cross chain swaps can display the fees in the tx details
There was a problem hiding this comment.
can we cover this new behavior with a test to ensure new TX data overrides old data?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5704 +/- ##
========================================
Coverage 86.92% 86.92%
========================================
Files 782 782
Lines 32315 32315
Branches 5339 5633 +294
========================================
+ Hits 28090 28091 +1
+ Misses 4175 3984 -191
- Partials 50 240 +190
... and 78 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/transactions/feed/queryHelper.ts
Outdated
| ) | ||
| transactionsWithoutDuplicatedHash.sort((a, b) => { | ||
| const transactionsByTxHash: { [txHash: string]: TokenTransaction } = {} | ||
| existingTxs.forEach((transaction) => { |
There was a problem hiding this comment.
nit: can do
[...existingTxs, ...incomingTxs].forEach((transaction) => {
transactionsByTxHash[transaction.transactionHash] = transaction
})to save some space
| transactionHash: transaction.transactionHash || '', | ||
| block: '', | ||
| fees: [], | ||
| ...transaction, // in case the transaction already has the above (e.g. cross chain swaps), use the real values |
There was a problem hiding this comment.
can we cover this new behavior with a test to ensure new TX data overrides old data?
Description
This PR fixes a bug where pending cross chains swaps remain pending forever. The root cause is the query helper reconciles already received transactions with newly received transactions by preferring the already received transaction. This means that previously received pending swaps are not updated when the same transactions is received again with the completed status.
This is a bug that affects not only cross chain swaps (we should always prefer the newest information in case other fields in the transaction have changed.
Test plan
Cross chains swaps can be settled correctly
Related issues
n/a
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: