Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to use single header for destination headers #7

Merged
merged 3 commits into from
May 11, 2024

Conversation

gagasdiv
Copy link
Contributor

@gagasdiv gagasdiv commented May 8, 2024

Single destination headers are used in compliance with RFC 5322 (https://www.rfc-editor.org/rfc/rfc5322#section-3.6.3), which Gmail SMTP complained about. This affects the following headers:

  • To
  • Cc

Single destination headers are used in compliance with RFC 5322 (https://www.rfc-editor.org/rfc/rfc5322), which Gmail SMTP complained about. This affects the following headers:
- To
- Cc
@gagasdiv gagasdiv closed this May 8, 2024
@gagasdiv gagasdiv deleted the feat/single-destination-headers branch May 8, 2024 11:25
@valord577
Copy link
Owner

@gagasdiv Excuse me, why is this pr closed?

@gagasdiv
Copy link
Contributor Author

@gagasdiv Excuse me, why is this pr closed?

Ah, sorry, I meant to make this PR to the main branch in my own fork because I needed the changes real quick (I made it to your main branch by mistake).

I can restore the branch and reopen this PR if you want to implement this upstream.
Might note that I'm new to Go and don't know if my changes are up to standards.

Oh, and I like your library! Using it is quite easy, I was looking for a simple Go email library and this fits my project's needs quite well.

@valord577
Copy link
Owner

It's so kind of you. I hope to restore this PR.

According to this closed PR:

  • As code quality, if you restore the PR, I'll make small changes to your code.
  • For testing, you can send an email to the address provided by mail-tester, later it will give the report.

@gagasdiv gagasdiv restored the feat/single-destination-headers branch May 10, 2024 06:26
@gagasdiv gagasdiv reopened this May 10, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@valord577 valord577 merged commit 498cacf into valord577:main May 11, 2024
2 checks passed
@valord577
Copy link
Owner

@gagasdiv Thank you very much again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants