chore: add mint data #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidMinarsch
commented
May 2, 2023
| @@ -0,0 +1,9 @@ | |||
| token_id-"component_id" | |||
| X-"skill/valory/apy_estimation_abci/0.1.0" - 1, 4, 14 | |||
There was a problem hiding this comment.
1 and 4 should be removed as dependencies. One of them is not used in code, the other one is unnecessarily used.
There was a problem hiding this comment.
These are the abci and the http protocols, correct? Why should one of them be removed?
There was a problem hiding this comment.
They are pointlessly imported
DavidMinarsch
commented
May 2, 2023
| @@ -0,0 +1,9 @@ | |||
| token_id-"component_id" | |||
| X-"skill/valory/apy_estimation_abci/0.1.0" - 1, 4, 14 | |||
| X-"skill/valory/apy_estimation_chained_abci/0.1.0" - 14, 16, 17, 22, 33, "skill/valory/apy_estimation_abci/0.1.0" | |||
There was a problem hiding this comment.
Termination and transaction_settlement skills are missing in code.
DavidMinarsch
commented
May 2, 2023
| X-"skill/valory/apy_estimation_abci/0.1.0" - 1, 4, 14 | ||
| X-"skill/valory/apy_estimation_chained_abci/0.1.0" - 14, 16, 17, 22, 33, "skill/valory/apy_estimation_abci/0.1.0" | ||
| --- | ||
| token_id-"agent_id" |
There was a problem hiding this comment.
Why is the ipfs connection and skill not listed as a dependency?
There was a problem hiding this comment.
The IPFS connection and protocol are now listed as dependencies in #58.
Add termination and IPFS to the agent dependencies
Bump `open-aea` and `open-autonomy` frameworks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.