Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax python-dotenv dependency #740

Merged
merged 2 commits into from
May 22, 2024

Conversation

evangriffiths
Copy link

Proposed changes

Relax python-dotenv dependency. The only use of the package in open-aea is here https://github.com/valory-xyz/open-aea/blob/main/aea/helpers/base.py#L144. This is compatible with the newest release of python-dotenv.

Types of changes

No functional changes. Dependency change only.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@angrybayblade
Copy link

@evangriffiths Can you take a look at the failure and see if it has anything to do with the changes you made?

@angrybayblade
Copy link

@evangriffiths Can you sync your PR with main? I've merged the fix for the CI failure

@evangriffiths
Copy link
Author

I've merged the fix for the CI failure

@angrybayblade Thanks! Synced.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (9d887d6) to head (3229a1c).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   90.21%   90.06%   -0.16%     
==========================================
  Files         373      373              
  Lines       29899    29971      +72     
==========================================
+ Hits        26974    26994      +20     
- Misses       2925     2977      +52     
Flag Coverage Δ
unittests 90.06% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade merged commit ca9f81c into valory-xyz:main May 22, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants