[0.3.2] Replace start timestamp with number of observations #1402
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ license: Apache-2.0 | |
| fingerprint: | ||
| README.md: bafybeibhbkelnxxvsln677imq65vgbglmlhyxtax4iqtzempjiwcoef3gq | ||
| fingerprint_ignore_patterns: [] | ||
| agent: valory/apy_estimation:0.1.0:bafybeidvbcjss3lkw24if4gzi33nsixcxglcluahsp7bzh7omeqhzjdb6a | ||
| number_of_agents: 4 | ||
| --- | ||
| public_id: valory/apy_estimation_abci:0.1.0 | ||
|
|
@@ -22,7 +22,7 @@ models: | |
| spooky_subgraph: | ||
| - '0x2a651563c9d3af67ae0388a5c8f89b867038089e' | ||
| - '0x2b4c76d0dc16be1c31d4c1dc53bf9b45987fc75c' | ||
| n_observations: ${SERVICE_APY_N_OBSERVATIONS:int:120} | ||
|
There was a problem hiding this comment. Set a default of 120 observations which is a good number to start experimenting with. Moreover, now the operator does not need to specify anything if they do not need to update the number of observations. Previously, they had to update the There was a problem hiding this comment. yes. There probably is some range that should be allowed, not up to infinity There was a problem hiding this comment. In aea-config.yaml n_observations is 10 while here it is 120. Is that right? There was a problem hiding this comment. Agreed. I plan to extend this method at some point, though we might want to introduce a proper way for validation to all of our models: open-autonomy/packages/valory/skills/apy_estimation_abci/models.py Lines 209 to 220 in 554269b Have you heard of pydantic? Using it might produce some cool results. There was a problem hiding this comment.
Yes, we need the service to run with proper values and the CI to run fast. |
||
| history_end: null | ||
| ipfs_domain_name: /dns/registry.autonolas.tech/tcp/443/https | ||
| server_api: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -306,7 +306,7 @@ def setup(self) -> None: | |
|
|
||
| self._unit = sec_to_unit(self.params.interval) | ||
| self._target_per_pool = int( | ||
| unit_amount_from_sec(self.params.ts_length, self._unit) | ||
|
There was a problem hiding this comment. We now have a property for this: open-autonomy/packages/valory/skills/apy_estimation_abci/models.py Lines 204 to 207 in 554269b |
||
| ) | ||
| n_ids = sum( | ||
| (len(dex_pair_ids) for dex_pair_ids in self.params.pair_ids.values()) | ||
|
|
@@ -361,14 +361,15 @@ def _check_given_pairs(self) -> Generator[None, None, None]: | |
|
|
||
| def _reset_timestamps_iterator(self) -> None: | ||
| """Reset the timestamps iterator.""" | ||
| # `start` and `end` are set in the `setup` method and therefore cannot be `None` at this point | ||
| start = cast(int, self.params.start) | ||
| end = cast(int, self.params.end) | ||
|
|
||
| if self.batch: | ||
| self._progress.timestamps_iterator = iter((end,)) | ||
| else: | ||
| self._progress.timestamps_iterator = gen_unix_timestamps( | ||
| start, self.params.interval, end | ||
| ) | ||
|
|
||
| def _set_current_progress(self) -> None: | ||
|
|
@@ -1402,7 +1403,6 @@ def async_act(self) -> Generator: | |
| self.context.logger.info( | ||
| "Estimates have been received:\n" f"{estimates.to_string()}" | ||
| ) | ||
|
|
||
|
Comment on lines
1403
to
1406
There was a problem hiding this comment. Removed because it was duplicate. |
||
| # Send the file to IPFS and get its hash. | ||
| self._estimations_hash = self.send_to_ipfs( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increased timeout as I have noticed windows tests timing out lately and I also added two new
hypothesistests.