Test/solana #2139
Test/solana #2139
Conversation
| def _decode_instructions(instructions: str) -> List[Any]: | ||
| """Decode the instructions.""" | ||
| instructions = json.loads(instructions) | ||
| return [json.loads(instruction) for instruction in instructions] |
There was a problem hiding this comment.
@Adamantios suggests we should store this in a serialized form. It will make such rounds much simpler in the future. I agree with that suggestion.
There was a problem hiding this comment.
So I tried to address this here d2a88ad
The contract method was returning a serialised instruction string instead of a dictionary object, I updated the transfer ix method to return a dictionary to match the rest of the methods
| # the check whether its solana is temporary until we have issues in the plugin | ||
| # fixed https://github.com/valory-xyz/open-aea/pull/708#discussion_r1448366974 | ||
| if tx_hash != tx_hash_backup and chain_id != SOLANA_LEDGER_ID: |
There was a problem hiding this comment.
this should not be the case anymore, that PR is merged @angrybayblade
| @@ -1687,6 +1690,7 @@ def get_contract_api_response( | |||
| contract_address: Optional[str], | |||
| contract_id: str, | |||
| contract_callable: str, | |||
| ledger_id: Optional[str] = None, | |||
| def _decode_instructions(instructions: str) -> List[Any]: | ||
| """Decode the instructions.""" | ||
| instructions = json.loads(instructions) | ||
| return [json.loads(instruction) for instruction in instructions] |
| # TOFIX - anchorpy has a conflict with tomte[tests] | ||
| package_dependencies.pop("open-aea-ledger-solana") | ||
| package_dependencies.pop("solders") |
There was a problem hiding this comment.
I'll create a tomte release with a fix
angrybayblade
force-pushed
the
test/solana
branch
2 times, most recently
from
c013063
to
73cced5
Compare
angrybayblade
force-pushed
the
test/solana
branch
from
73cced5
to
36c1572
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/solana #2139 +/- ##
===============================================
+ Coverage 94.21% 94.48% +0.26%
===============================================
Files 262 257 -5
Lines 15989 15917 -72
===============================================
- Hits 15064 15039 -25
+ Misses 925 878 -47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Changes look good @angrybayblade , I cannot approve as I am the PR creator.
Proposed changes
This PR:
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...