Add bang methods

[bradleyd]

• Add bang functions for HTTP requests.
• Return ErrorResponse struct by default when there is an issue.
• Add catch all for Response#success?

I bumped version to 2.3.0 not sure how you would want to handle it.

[bradleyd]

now that I think about it..maybe the version should be bumped to 3.0.0 since technically they are breaking changes.

[valpackett]

About the version – I'll bump it to 3.0.0 later, please don't touch the version in pull requests.

Seems reasonable overall, except you're duplicating the raise code everywhere. Make a request! method that does the exception throwing and make other bang methods call it!

[bradleyd]

i will make changes and return the version back to what it was...sorry about that.

[bradleyd]

@myfreeweb better? BTW, thanks for the feedback.

[valpackett]

Uh… almost. Except not really better. Please don't add any code duplication — Don't Repeat Yourself! (or others)

I meant something like this:

      @doc """
      Like `request`, but raises  `HTTPotion.HTTPError` if failed.
      """
      @spec request!(atom, String.t, [{atom(), any()}]) :: %HTTPotion.Response{} | %HTTPotion.AsyncResponse{}
      def request!(method, url, options \\ []) do
        case request(method, url, options) do
          %HTTPotion.ErrorResponse{message: message} ->
            raise HTTPotion.HTTPError, message: message
          response -> response
        end
      end

Also, the @spec for the non-bang request should include %HTTPotion.ErrorResponse{} in the list of return types.

[bradleyd]

@myfreeweb 3rd time is a charm =]

[valpackett]

Looks good, thanks!

[bradleyd]

Thank you!

[chibicode]

@myfreeweb could you bump the version?