Skip to content
This repository has been archived by the owner on Oct 16, 2022. It is now read-only.

magicbane-0.2.0 build failure with http-conduit-2.3 #9

Closed
DanBurton opened this issue Mar 12, 2018 · 4 comments
Closed

magicbane-0.2.0 build failure with http-conduit-2.3 #9

DanBurton opened this issue Mar 12, 2018 · 4 comments

Comments

@DanBurton
Copy link

As seen on the Stackage build server:

magicbane: BuildFailureException Process exited with ExitFailure 1: ./Setup build

[6 of 9] Compiling Magicbane.HTTPClient ( library/Magicbane/HTTPClient.hs, dist/
build/Magicbane/HTTPClient.o )

library/Magicbane/HTTPClient.hs:69:25: error:
    • Could not deduce (unliftio-core-0.1.1.0:Control.Monad.IO.Unlift.MonadUnlif
tIO
                          μ)
        arising from a use of ‘HCC.withResponse’
      from the context: (MonadHTTP ψ μ, MonadCatch μ)
        bound by the type signature for:
                   performWithFn :: forall ψ (μ :: * -> *) ι ρ.
                                    (MonadHTTP ψ μ, MonadCatch μ) =>
                                    (ConduitM ι ByteString μ () -> μ ρ)
                                    -> Request -> ExceptT Text μ (Response ρ)
        at library/Magicbane/HTTPClient.hs:67:1-122
      Possible fix:
        add (unliftio-core-0.1.1.0:Control.Monad.IO.Unlift.MonadUnliftIO
               μ) to the context of
          the type signature for:
            performWithFn :: forall ψ (μ :: * -> *) ι ρ.
                             (MonadHTTP ψ μ, MonadCatch μ) =>
                             (ConduitM ι ByteString μ () -> μ ρ)
                             -> Request -> ExceptT Text μ (Response ρ)
    • In the expression: HCC.withResponse req
      In the second argument of ‘($)’, namely
        ‘HCC.withResponse req
           $ \ res
               -> do body <- fn $ responseBody res
                     return res {responseBody = body}’
      In the second argument of ‘($)’, namely
        ‘tryAny
           $ HCC.withResponse req
               $ \ res
                   -> do body <- fn $ responseBody res
                         return res {responseBody = body}’
   |
69 |   res ← lift $ tryAny $ HCC.withResponse req $ \res → do
   |                         ^^^^^^^^^^^^^^^^^^^^

I was able to reproduce locally like so:

stack unpack magicbane-0.2.0 && cd magicbane-0.2.0
edit stack.yaml # add the following stack.yaml
stack build
# stack.yaml
resolver: nightly-2018-03-10
extra-deps:
- servant-0.13
- servant-server-0.13
- http-types-0.12.1
- http-conduit-2.3.0
DanBurton added a commit to commercialhaskell/stackage that referenced this issue Mar 12, 2018
@DanBurton
Copy link
Author

I've removed magicbane from the Stackage nightly build plan, and unfortunately it won't appear in the initial LTS 11 release.

To get back into nightly, open a PR on the Stackage repo as usual. To get into LTS 11, open an issue on https://github.com/fpco/lts-haskell/issues.

@akhra
Copy link
Contributor

akhra commented Mar 23, 2018

I think the only thing still missing here is a version bump and a hackage distribution?

@valpackett
Copy link
Owner

valpackett commented Mar 23, 2018

Yeah. I think I'll also do #11 first. (hmm actually, rio is not released yet…)

@jkachmar
Copy link

It looks like this has been resolved (at least as of LTS 12.14 magicbane is on Stackage again).

Can this issue be closed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants