Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(SAAS-527): upgrade dependencies to resolve vulnerabilities #171

Merged
merged 6 commits into from
Jul 19, 2023
Merged

chore(SAAS-527): upgrade dependencies to resolve vulnerabilities #171

merged 6 commits into from
Jul 19, 2023

Conversation

FabioValtech
Copy link
Contributor

Description

  • fix linting
  • remove unused dependencies
  • remove @valtech/eslint-config as it is deprecated
  • updated dependencies to resolve vulnerabilities

Related Issues

https://jira.valtech.com/browse/SAAS-527

How Has This Been Tested?

run all commands (but publish ofc) locally with no error

Screenshots (if you're changing CSS, AEM Dialogs: add Screenshots, GIFs or movies indicating your change):

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly: JavaDoc, Readme.md files, etc
  • I have checked Sonar Results.
  • I have added tests to cover my changes.

@FabioValtech
chore(SAAS-527): upgrade dependencies to resolve vulnerabilities
85b2c37 
- fix linting
- remove unused dependencies
- remove @valtech/eslint-config as it is deprecated
@olivark
Copy link

olivark commented Jul 19, 2023 •
edited
Loading

@nhirrle

  • update .github/workflows/npm-publish.yml (added the npm run package command)
  • update ui.frontend/webpack.npm.js (removed unused imports)

olivark
olivark reviewed Jul 19, 2023
View reviewed changes
ui.frontend/tsconfig.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nhirrle nhirrle merged commit 8f2c049 into main Jul 19, 2023
4 checks passed
@nhirrle nhirrle deleted the chore/SAAS-527 branch July 19, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivark olivark olivark left review comments

@nhirrle nhirrle nhirrle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@FabioValtech @olivark @nhirrle @kevinolivar