Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drain event on publish (comes via the underlying node-amqp-connection-manager dependency) #20

Open
EricWasTakenMJD opened this issue Aug 12, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@EricWasTakenMJD
Copy link
Contributor

EricWasTakenMJD commented Aug 12, 2021

Note that dependency: node-amqp-connection-manager currently has a reported bug (possibly?) and does not currently handle drain events. While it guarantees receipt of all published messages, it does not resend failed messages when a drain emit is fired. This would ideally be fixed in the library and allow us to resend on drain as we did previously (instead of on a fixed time interval).

See jwalton/node-amqp-connection-manager#129 for the dependency issue.

Is this causing issues with AMQP Cacoon also?

Requires research and is left as a possible future fix for AMQPCacoon.

@EricWasTakenMJD
Copy link
Contributor Author

This is possibly fixed in https://github.com/jwalton/node-amqp-connection-manager/releases/tag/v3.2.3 - at least it's referenced there as resolved.

@EricWasTakenMJD EricWasTakenMJD added the bug Something isn't working label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant