Bugfix/233 store as binary #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 29, 2024 10:47
…if that's the case it will be stored as binary
nhirrle
reviewed
May 29, 2024
| @@ -77,6 +86,9 @@ public class HistoryUtil { | |||
| protected static final String ATTR_START = "start"; | |||
| protected static final String ATTR_END = "end"; | |||
| private static final String NAME_INDEX = "oak:index"; | |||
| // This size is limited by the LuceneDocumentMaker to be able to read the property and create the new index | |||
| // The limit is 102400 but just to be in the safe side, is set to a bit lower number | |||
| private static final int MAXIMUN_PROPERTY_SIZE = 100000; | |||
There was a problem hiding this comment.
typo: MAXIMUN_PROPERTY_SIZE -> MAXIMUM_PROPERTY_SIZE
| @@ -358,7 +370,21 @@ private void saveExecutionResultInHistory(ExecutionResult result, String path, R | |||
| values.put(ATTR_RUN_STATE, result.getState().name()); | |||
| values.put(ATTR_PATH, result.getPath()); | |||
| if (StringUtils.isNotBlank(result.getOutput())) { | |||
| values.put(ATTR_RUN_OUTPUT, result.getOutput()); | |||
| if (result.getOutput().getBytes(StandardCharsets.UTF_8).length < MAXIMUN_PROPERTY_SIZE) { | |||
There was a problem hiding this comment.
small change suggestion: store full data in seperate property in case it is too big. like that we don't need to check type of the property when reading.
if (result.getOutput().getBytes(StandardCharsets.UTF_8).length > MAXIMUM_PROPERTY_SIZE) {
values.put(ATTR_RUN_OUTPUT, "Output data too big, full data is stored as a binary in runOutputFull");
values.put(ATTR_RUN_OUTPUT_FULL, new ByteArrayInputStream(result.getOutput().getBytes(StandardCharsets.UTF_8)));
LOG.info("Script result is bigger than 100 000 bytes. Full data can be found as a binary in property runOutputFull for path " + path );
}
nhirrle
approved these changes
May 29, 2024
|
I would appreciate if you could publish a minor version with the latest changes Thanks! |
|
just released it, thanks for your contributions @pcastelog ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will solve #233