Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert code to native JS classes #2

Merged

Conversation

DmitrySharabin
Copy link
Contributor

Hey there, 👋🏻

Could you please review this PR and if you are OK with the changes push the fix? It will help Mavo authors to continue using your awesome plugin.

Btw, I also noticed that Mavo can't find you plugin via this URL: https://cdn.jsdelivr.net/gh/valterkraemer/mavo-couchdb@latest/mavo-couchdb.js. 😔 Is there a chance you know why it happens? We need to fix this issue as well.

@valterkraemer valterkraemer merged commit fb24258 into valterkraemer:master Dec 9, 2022
@valterkraemer
Copy link
Owner

Hey there, 👋🏻

Could you please review this PR and if you are OK with the changes push the fix? It will help Mavo authors to continue using your awesome plugin.

Btw, I also noticed that Mavo can't find you plugin via this URL: https://cdn.jsdelivr.net/gh/valterkraemer/mavo-couchdb@latest/mavo-couchdb.js. 😔 Is there a chance you know why it happens? We need to fix this issue as well.

Great, thanks!

No idea regarding the jsdelivr thing. But now when navigating to that link it seems to be working 🤷‍♂️

@DmitrySharabin
Copy link
Contributor Author

But now when navigating to that link it seems to be working

Yay! Thank you so much. 🙏🏻

@DmitrySharabin DmitrySharabin deleted the native-js-classes branch December 9, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants